Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Unify provision/retire tabs and output for Services #9292

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] Unify provision/retire tabs and output for Services #9292

wants to merge 1 commit into from

Conversation

agrare
Copy link
Member

@agrare agrare commented Oct 21, 2024 •
edited
Loading

No specs and not live tested yet

Ref: #9285 (comment)

@agrare agrare requested a review from a team as a code owner October 21, 2024 18:26
@agrare agrare mentioned this pull request Oct 21, 2024
Merged
@Fryguy Fryguy added the wip label Jan 15, 2025
@miq-bot
Copy link
Member

miq-bot commented Mar 5, 2025

Checked commit agrare@e3100c0 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
1 file checked, 5 offenses detected

app/views/service/_svcs_show.html.haml

  • ⚠️ - Line 34 - Line is too long. [128/80]
  • ⚠️ - Line 34 - Style/Semicolon: Do not use semicolons to terminate expressions.
  • ⚠️ - Line 38 - Line is too long. [152/80]
  • ⚠️ - Line 40 - Line is too long. [128/80]
  • ⚠️ - Line 6 - Avoid using instance variables in partials views

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
wip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agrare @miq-bot @Fryguy